geido opened a new issue #16894:
URL: https://github.com/apache/superset/issues/16894


   When setting up hierarchical filters, the user might select the parent 
filter to be the child filter and the child filter to be the parent. While this 
is an obvious mistake from the user, the UI should not freeze but should 
instead emit a proper error.
   
   #### How to reproduce the bug
   
   1. Go to a Dashboard
   2. Add a filter named "Parent Filter"
   3. Add another filter named "Child Filter"
   4. Set the "Child Filter" to use the "Parent Filter" in the hierarchy
   5. Set the "Parent Filter" to use the "Child Filter" in the hierarchy
   6. Click on Save
   7. Observe that the UI freezes out
   
   ### Expected results
   
   The UI should emit a proper error, such "Cannot used child filter as parent"
   
   ### Actual results
   
   The UI freezes and no humanly understandable error is emitted
   
   #### Screenshots
   
   
https://user-images.githubusercontent.com/60598000/135250851-4f424819-d7e2-4bb1-b314-ead1c66b3ab5.mp4
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version: chrome
   - superset version: `superset version` latest master 
   - python version: `python --version`
   - node.js version: `node -v`
   - any feature flags active: native filters and cross-filters
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version 
of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to