geido opened a new pull request #16923:
URL: https://github.com/apache/superset/pull/16923


   ### SUMMARY
   Checks whether `operatorId` is undefined in an `AdhocFilter` as a quick fix 
for a bug that wouldn't allow the user the change the column of a filter. 
However, more investigation is required in order to understand why the 
`operatorId` was undefined in the first place.
   
   ### BEFORE
   
https://user-images.githubusercontent.com/81597121/135327094-6c5b3b46-9853-4f70-97fa-73b745d1778b.mov
   
   ### AFTER
   
https://user-images.githubusercontent.com/60598000/135480563-092405ce-41c7-4e7e-bedb-41508057989b.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open the sample chat "First time developer?"
   2. Edit the existing filter and change the column
   3. Make sure the column can be changed 
   
   _Originally reported here 
https://github.com/apache/superset/pull/16871#issuecomment-930433964_
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: 
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to