etr2460 commented on issue #16792: URL: https://github.com/apache/superset/issues/16792#issuecomment-932375790
Oh sorry, one more thing (but not blocking): Under cypress you have: >Prefer data-test attributes to isolate selectors from eventual CSS, JS or text content changes. Isn't that the opposite as what we recommend for RTL? If it's best practices, then I guess it's fine. But maybe we should further call out why we have 2 different recommendations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
