EBoisseauSierra opened a new issue #16956:
URL: https://github.com/apache/superset/issues/16956


   When the import of a dashboard export fails, the logger lists an exception 
but the Python script exits as successful. This is a bit counter-intuitive as 
the import/export has actually failed.
   
   #### How to reproduce the bug
   
   1. Import a non-working export ZIP archive,
   2. The exception is caught by [that broad `except Exception` 
catch](https://github.com/apache/superset/blob/master/superset/cli.py#L358-L362).
   3. The Python script exits with a `0` exit code.
    
   ### Expected results
   
   Because the command has effectively failed to execute, I expect the Python 
script to exits with a non-0 exit code.
   
   ### Actual results
   
   0-exit code.
   
   ### Environment
   
   - superset version: `1.3.0`
   - python version: `3.8.12`
   - any feature flags active: `"VERSION_EXPORT": True`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to