[GitHub] [superset] michael-s-molina commented on pull request #16154: feat(dashboard): Let users re-arrange native filters

[GitBox]

michael-s-molina commented on pull request #16154:
URL: https://github.com/apache/superset/pull/16154#issuecomment-933743212


   @m-ajay I was just checking the latest version of the interface and I found 
many differences in relation to what we have on master. 
   
   This is the master version:
   
   <img width="900" alt="Screen Shot 2021-10-04 at 3 01 57 PM" 
src="https://user-images.githubusercontent.com/70410625/135901213-192ed6d3-5183-4ddf-b353-c53bfc84ec4b.png";>
   
   This is the latest version of this branch:
   
   <img width="897" alt="Screen Shot 2021-10-04 at 2 57 04 PM" 
src="https://user-images.githubusercontent.com/70410625/135901265-93086915-14dc-4a64-a0ff-397aeca6919e.png";>
   
   I marked some of the differences:
   
   - Double vertical bars on the left panel. The bar is appearing even if we 
have only one item.
   - The Add Filter button is disappearing from the screen
   - The top margin on the right panel is different
   - We have a vertical scrollbar on the right panel even when the content fits
   - The right border of the collapse panel is duplicated, giving the 
impression that is thicker than the other borders
   - The selected filter state is different. Previously we had a background 
color indicating the selected filter
   - The left padding on the left panel is different. Look how the filters are 
aligned with the Filters title on master
   
   About the new feature:
   - I noticed that the cursor is changing (grab/grabbing) only when I drag 
using the icon but if I drag using the name the cursor does not change
   - The drag image contains a bottom padding
   - The hover is changing the color of the text and delete icon but not the 
hover icon
   
   These points are just something that I noticed very quickly but maybe we can 
have more. I suggest that you compare the proposed view with the one on master 
to make sure the behaviors are the same with the added drag and drop 
functionality.
   
   Just ping me if any of these points are not clear or if you need any help 😉 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org