betodealmeida commented on a change in pull request #16941:
URL: https://github.com/apache/superset/pull/16941#discussion_r721735916
##########
File path: superset/datasets/commands/update.py
##########
@@ -98,8 +98,9 @@ def validate(self) -> None:
exceptions.append(DatabaseChangeValidationError())
# Validate/Populate owner
try:
- owners = self.populate_owners(self._actor, owner_ids)
- self._properties["owners"] = owners
+ if owner_ids:
+ owners = self.populate_owners(self._actor, owner_ids)
+ self._properties["owners"] = owners
Review comment:
Hugh, this will make the dataset update command behave differently than
all other commands.
Why are we not passing the list of current owners when doing the `PUT`
request? That would solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
