villebro commented on a change in pull request #16994:
URL: https://github.com/apache/superset/pull/16994#discussion_r724064959
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
##########
@@ -63,7 +63,8 @@ const FilterControls: FC<FilterControlsProps> = ({
dataMask: dataMaskSelected[filter.id],
}));
return buildCascadeFiltersTree(filtersWithValue);
- }, [filterValues, dataMaskSelected]);
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ }, [JSON.stringify(filterValues), dataMaskSelected]);
Review comment:
> Ah, now I see that `useFilters` hooks returns `Object.entries` which
creates a new object on each run... Yeah, that means that it probably needs
`JSON.stringify`, but in general I'm not sure if the pattern used in
`useFilters` is good
I agree, it's definitely an antipattern. However, until we have a guideline
for avoiding them I'd suggest going with `JSON.stringify` for now, leaving a
`// TODO:` here and then cleaning these stringifys up in follow-up refactor PRs
once we've settled on a good pattern for being able to use strict equality in
the deps arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
