krsnik93 commented on a change in pull request #16606:
URL: https://github.com/apache/superset/pull/16606#discussion_r724229485
##########
File path: superset/commands/importers/v1/__init__.py
##########
@@ -112,8 +112,11 @@ def validate(self) -> None:
# populate passwords from the request or from existing DBs
if file_name in self.passwords:
config["password"] = self.passwords[file_name]
- elif prefix == "databases" and config["uuid"] in
db_passwords:
- config["password"] = db_passwords[config["uuid"]]
+ elif (
+ prefix == "databases"
+ and config["database_name"] in db_passwords
Review comment:
@EBoisseauSierra replacing `config["database_name"]` with
`config.get("database_name")` should make the only failing test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
