geido opened a new pull request #17018: URL: https://github.com/apache/superset/pull/17018
### SUMMARY The SUPERSET_DEFAULT theme should not be considered as an independent color scheme as it is just a reference to an existing color scheme that is already part of the list of schemes. This PR excludes the SUPERSET_DEFAULT from the options of color schemes while keeping retro-compatibility with those that use SUPERSET_DEFAULT as a scheme. ### BEFORE See issue #16962 ### AFTER https://user-images.githubusercontent.com/60598000/136429051-935feaa3-efce-477e-a742-bb1f915a5786.mp4 ### TESTING INSTRUCTIONS 1. Open a Dashboard and edit the properties 2. View the color scheme options and make sure there are no duplicates 3. Select the D3Category10 option and make sure the right color scheme is represented in the advanced - json metadata ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #16962 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
