john-bodley commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724329925
##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# pylint: disable=arguments-renamed
Review comment:
@ofekisr could we move these to the lines where the issue occurs? There
was an effort in https://github.com/apache/superset/pull/16589 to remove
top-level Pylint disable checks as it's i) unclear to the reader where these
violations are occurring, and ii) potentially masks issues in future changes.
I realize that this wasn't clear and so adding it to the `CONTRIBUTING.md`
in https://github.com/apache/superset/pull/17016.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
