EBoisseauSierra commented on pull request #16606: URL: https://github.com/apache/superset/pull/16606#issuecomment-938159662
@krsnik93 you're right: this PR aimed to fix an issue we had where using _the same_ URI on two different machine yield to two different UUID (I haven't investigated where they are generated) — so the matching at import is failing (the pw in the archive is masked, and even if the URI/db connection already exist in Superset thanks to the set-database-uri, it is not reconciled because of the different UUIDs). But this issue of non-deterministic/reproducible UUIDs (and thus, failing import) — that my PR tries to solve by using the db connection name as lookup key — is, IMHO, a subset of a more generic problem that is “how to import-dashboards, but update the db URI on the fly?” (or use the previously instantiated db connection, using db connection name as lookup key). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
