geido commented on pull request #16637: URL: https://github.com/apache/superset/pull/16637#issuecomment-937771987
@kgabryje @villebro what I found is that even in the current implementation the `label_colors` should be polluting the URL but in some cases the scale is just returning empty, that's the reason why it seems that the URL isn't affected. The correct solution here is to remove the `label_colors` from the `formData` and pass them directly to the chart so that the URL won't ever be polluted. This is the change that I just did. It remains the problem of how we pass the label colors to the chart when coming from the Dashboard to Explore. However, that is a much bigger problem and will need to be tackled in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
