villebro commented on a change in pull request #17017:
URL: https://github.com/apache/superset/pull/17017#discussion_r724734875
##########
File path: tests/unit_tests/db_engine_specs/test_bigquery.py
##########
@@ -59,19 +59,7 @@ def test_get_fields(app_context: AppContext) -> None:
columns = [{"name": "limit"}, {"name": "name"}, {"name": "project.name"}]
fields = BigQueryEngineSpec._get_fields(columns)
- # generic SQL
query = select(fields)
- assert (
- str(query)
- == 'SELECT "limit" AS "limit", name AS name, "project.name" AS
project__name'
- )
-
- # BigQuery-specific SQL
- try:
- from pybigquery.sqlalchemy_bigquery import BigQueryDialect
- except ModuleNotFoundError:
- return
-
Review comment:
Minor nit: to make sure the test suite can be run even in the absence of
BQ deps, we can probably add `pytest.importorskip("pybigquery") here so that
`pytest` shows that this test is skipped if the BQ connector isn't available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
