kgabryje commented on a change in pull request #17025:
URL: https://github.com/apache/superset/pull/17025#discussion_r724902497
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx
##########
@@ -23,21 +23,21 @@ import { Provider } from 'react-redux';
import { nativeFiltersInfo } from
'spec/javascripts/dashboard/fixtures/mockNativeFilters';
import CascadeFilterControl, { CascadeFilterControlProps } from '.';
-const mockedProps = {
+const mockedProps = (defaultsId = nativeFiltersInfo.filters.DefaultsID) => ({
Review comment:
Can we change the name to indicate that it's a function? Like
`getMockedProps`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
