pkdotson opened a new pull request #17034: URL: https://github.com/apache/superset/pull/17034
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This pr fixes issue where trash icon shows in markdown component when not in edit mode. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF after https://user-images.githubusercontent.com/17326228/136568990-52d48775-03d3-4d91-a73f-eab429402259.mov ### TESTING INSTRUCTIONS Trash icon should not show in markdown when not in edit mode. <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x ] Has associated issue: Fixes https://github.com/apache/superset/issues/16981 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
