michael-s-molina edited a comment on issue #16792: URL: https://github.com/apache/superset/issues/16792#issuecomment-938673521
> I'm not sold on the "Avoid nesting when you're testing" point. I personally like the abstractions and groupings and dryer code that comes from that long-used pattern. If most other people are really in favor of this new pattern, then that's cool, but it's not my first choice. No problem! I personally prefer to avoid `describe` because of the points described in Kent C. Dodds article but I'm also fine if the majority chooses to use it. > Can we add more explanation to these points so that people reading in the future also understand the why: Yes! Will do. > Can we instead of discouraging people from using Cypress just relay the difference between end-to-end and integration tests? We still need people to continue to write end to end tests. :) I was reading again and you're right! We can make it more clear that we're favoring RTL for integration tests when possible but Cypress remains essential for e2e tests. Nice catch! > when does the afterEach not run? I think it's better to clean up after yourself than after someone else. :) @geido Can you detail this? > Another common antipattern is that people will add classes or ids just for testing. I know we're talking about using roles and test-ids, etc, but do you think we can explicitly discourage adding anything into code for testing except for a test-id? I think so. Do you have a sentence in mind to make it more clear? You can reply here or edit the issue's description directly 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
