yongchand opened a new pull request #17039: URL: https://github.com/apache/superset/pull/17039
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Add alternative option for issue #16944 If people think this should be default, I may just remove from config and simply change true -> false ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> **Before:** https://user-images.githubusercontent.com/43336767/136601879-c3ea7040-5944-43b6-bf05-15d7f29ef22a.mov When DASHBOARD_FORCE_AUTO_REFRESH is True, chart will query every time when it auto-refreshes. **After:** https://user-images.githubusercontent.com/43336767/136601893-a876f406-6190-4d90-bffb-e78e4eaa8661.mov When DASHBOARD_FORCE_AUTO_REFRESH is False, chart will use cache if it exist during auto-refresh. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Since this PR requires to change superset-ui to change, you can test by following step instead. 1. Open dashboard with several charts with cache of certain period (Say 300s) 2. Check that chart will not use cache at all (like before video) during auto-refresh 3. Change fetchCharts(xx, True, xx, xx) to fetchCharts(xx, false, xx, xx) 4. Check that chart use cache during auto-refresh ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
