betodealmeida opened a new pull request #17044: URL: https://github.com/apache/superset/pull/17044
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes a bug where after adding a dataset the modal would not reset properly. For example, adding if a user added, `database.schema.table`, when they tried to add another dataset the model would be already populated with `database`, `schema` and `table` on the dropdowns. While troubleshooting the problem I also cleaned up the code. `<TableSelector>` would take as props both a `database` object as well as a database ID. The logic was not correct so they were falling out of sync. I modified the component to take only a database object. I also consolidated a database type that was used in slightly different ways — the only difference was that one had `allow_multi_schema_metadata_fetch` and the other didn't. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/1534870/136627427-e5413f52-ca53-44b5-986b-b54ad83e2b6f.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Add a dataset; add another. Modal should be empty when it loads. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
