[GitHub] [superset] aniaan opened a new pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions

[GitBox]

aniaan opened a new pull request #17048:
URL: https://github.com/apache/superset/pull/17048


   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   The elasticsearch `CAST` function does not take effect for the `time zone` 
setting. In ES7.8 and above, we can use the `DATETIME_PARSE` function to solve 
this problem.
   
   In the current master code, the `extra` dict in the database contains the 
`version` key. We can use version to solve this problem. According to the 
instructions, version is set for `presto` at the beginning, and ES should also 
reuse this field.
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   1. Install the latest elasticsearch-dbapi version, 0.2.6, which supports 
setting the time_zone parameter `pip install elasticsearch-dbapi==0.2.6`
   2. Follow the steps in #16726 to create an ES data source, create a data 
source, set the time_zone parameter and version
   <img width="530" alt="截屏2021-10-09 下午4 47 33" 
src="https://user-images.githubusercontent.com/40813941/136651378-32fe75c1-a703-416d-ae7c-cdf3db122bb4.png";>
   
   3. Follow the operation steps in #16726 to analyze, and you can see that the 
DATETIME_PARSE function and time_zone parameter play a correct role
   
   <img width="1903" alt="截屏2021-10-09 下午4 50 14" 
src="https://user-images.githubusercontent.com/40813941/136651464-9e86c7b8-c2ae-4026-b09c-62f36aacfb02.png";>
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #16726
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org