john-bodley commented on a change in pull request #17050:
URL: https://github.com/apache/superset/pull/17050#discussion_r725507332
##########
File path: superset/db_engine_specs/druid.py
##########
@@ -41,26 +41,26 @@ class DruidEngineSpec(BaseEngineSpec):
_time_grain_expressions = {
None: "{col}",
- "PT1S": "FLOOR({col} TO SECOND)",
+ "PT1S": "TIME_FLOOR({col}, 'PT1S')",
"PT5S": "TIME_FLOOR({col}, 'PT5S')",
"PT30S": "TIME_FLOOR({col}, 'PT30S')",
- "PT1M": "FLOOR({col} TO MINUTE)",
+ "PT1M": "TIME_FLOOR({col}, 'PT1M')",
"PT5M": "TIME_FLOOR({col}, 'PT5M')",
"PT10M": "TIME_FLOOR({col}, 'PT10M')",
"PT15M": "TIME_FLOOR({col}, 'PT15M')",
"PT0.5H": "TIME_FLOOR({col}, 'PT30M')",
Review comment:
@villebro I've never understood why this is `PT0.5H` ("Half hour") as
opposed to `PT30M` ("30 minute"). I was thinking of doing a pass to change
these—which will require a database migration. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
