michael-s-molina opened a new pull request #17056:
URL: https://github.com/apache/superset/pull/17056


   ### SUMMARY
   Replaces `src/reduxUtils/areObjectsEqual` occurrences with Lodash 
`isEqualWith` and adds default customizers. The removed `areObjectsEqual` 
function was using `omitBy` to remove `undefined` values before passing the 
object to Lodash `isEqual`. A more efficient way is to pass a customizer to 
`isEqualWith` ignoring the `undefined` values during the comparison. Apart from 
the efficiency gain, this PR also aims to provide a utility with default 
customizers to be used throughout the application and that can be enhanced in 
the future with more custom functions.
   
   Follow-up of https://github.com/apache/superset/pull/16994
   
   @rusackas @junlincc 
   
   ### TESTING INSTRUCTIONS
   1 - Execute all tests
   2 - All tests should pass
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to