betodealmeida commented on a change in pull request #17063:
URL: https://github.com/apache/superset/pull/17063#discussion_r727295497
##########
File path: superset/connectors/base/models.py
##########
@@ -265,7 +265,11 @@ def data(self) -> Dict[str, Any]:
"metrics": [o.data for o in self.metrics],
# TODO deprecate, move logic to JS
"order_by_choices": order_by_choices,
- "owners": [owner.id for owner in self.owners],
+ # Passing the format needed to power owner selection in edit screen
+ "owners": [
+ {"label": f"{owner.first_name} {owner.last_name}", "value":
owner.id}
+ for owner in self.owners
+ ],
Review comment:
I assume we have endpoints where we can get full user information,
including first name and last name. The component should fetch from there and
build `label` and `value` however it needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
