john-bodley opened a new pull request #17079:
URL: https://github.com/apache/superset/pull/17079


   ### SUMMARY
   
   This PR fixes a regression I introduced in 
https://github.com/apache/superset/pull/17050 as it seems like the `P0.25Y` 
ISO8601 isn't supported, 
   
   ```
   druid> SELECT TIME_FLOOR(TIME_PARSE('2020-10-12'), 'P0.25Y')
   Unknown exception (java.lang.IllegalArgumentException): Invalid format: 
"P0.25Y"
   ```
   yet per the Druid SQL documentation for `TIME_FLOOR`
   
   > Rounds down a timestamp, returning it as a new timestamp. Period can be 
**any** ISO8601 period, like P3M (quarters) or PT12H (half-days).
   
   it explicitly states **any** ISO8601 format is acceptable. This change uses 
`P3M` instead (which is the direction o 
https://github.com/apache/superset/pull/17078).
   
   ### TESTING INSTRUCTIONS
   
   ```
   druid> SELECT TIME_FLOOR(TIME_PARSE('2020-10-12'), 'P3M')
   2020-10-01T00:00:00.000Z
   ```
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to