Karlodun commented on issue #17074:
URL: https://github.com/apache/superset/issues/17074#issuecomment-941616984


   
https://github.com/apache/superset/blob/master/superset/db_engine_specs/base.py,
 lines 1050-1061
   ```
    @classmethod
       def modify_url_for_impersonation(
           cls, url: URL, impersonate_user: bool, username: Optional[str]
       ) -> None:
           """
           Modify the SQL Alchemy URL object with the user to impersonate if 
applicable.
           :param url: SQLAlchemy URL object
           :param impersonate_user: Flag indicating if impersonation is enabled
           :param username: Effective username
           """
           if impersonate_user and username is not None:
               url.username = username
               
   ```
   I think what is missing here is something like:
   url.password = password  # this line is not sufficient
   
   Either this is missing, or probably it was never there and my bugreport 
should be replaced by a feature request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to