john-bodley commented on a change in pull request #17078:
URL: https://github.com/apache/superset/pull/17078#discussion_r727426351
##########
File path: superset/db_engine_specs/druid.py
##########
@@ -48,13 +48,13 @@ class DruidEngineSpec(BaseEngineSpec):
"PT5M": "TIME_FLOOR({col}, 'PT5M')",
"PT10M": "TIME_FLOOR({col}, 'PT10M')",
"PT15M": "TIME_FLOOR({col}, 'PT15M')",
- "PT0.5H": "TIME_FLOOR({col}, 'PT30M')",
+ "PT30M": "TIME_FLOOR({col}, 'PT30M')",
"PT1H": "TIME_FLOOR({col}, 'PT1H')",
"PT6H": "TIME_FLOOR({col}, 'PT6H')",
"P1D": "TIME_FLOOR({col}, 'P1D')",
"P1W": "TIME_FLOOR({col}, 'P1W')",
"P1M": "TIME_FLOOR({col}, 'P1M')",
- "P0.25Y": "TIME_FLOOR({col}, 'P0.25Y')",
+ "P3M": "TIME_FLOOR({col}, 'P3M')",
Review comment:
Apologies but https://github.com/apache/superset/pull/17050 introduced a
regression as it seemed that `P0.25Y` is not supported whereas `P3M` is, even
though the document suggests otherwise:
> Period can be any ISO8601 period, like P3M (quarters) or PT12H
(half-days).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
