villebro commented on a change in pull request #17006:
URL: https://github.com/apache/superset/pull/17006#discussion_r729073305
##########
File path:
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
##########
@@ -175,62 +184,80 @@ export default class AdhocFilterEditPopover extends
React.Component {
const stateIsValid = adhocFilter.isValid();
const hasUnsavedChanges = !adhocFilter.equals(propsAdhocFilter);
+ const sectionRenders = {};
Review comment:
Yes, this wasn't critique on your changes, just expressing that it'd be
nice if all code in `superset-frontend` were TS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
