betodealmeida commented on a change in pull request #17124:
URL: https://github.com/apache/superset/pull/17124#discussion_r729934038
##########
File path: superset-frontend/src/components/TimezoneSelector/index.tsx
##########
@@ -17,12 +17,16 @@
* under the License.
*/
-import React, { useEffect, useRef } from 'react';
+import React, { useEffect, useRef, useCallback } from 'react';
import moment from 'moment-timezone';
import { t } from '@superset-ui/core';
import { Select } from 'src/components';
-const DEFAULT_TIMEZONE = 'GMT Standard Time';
+const DEFAULT_TIMEZONE = {
+ name: 'GMT Standard Time',
+ value: 'Africa/Abidjan',
Review comment:
Ah, I see. I think it's fine. Maybe leave a comment saying that
timezones are deduped by the first alphabetical value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
