villebro opened a new pull request #17129: URL: https://github.com/apache/superset/pull/17129
### SUMMARY While checking licenses with [license-checker](https://www.npmjs.com/package/license-checker) on `superset-frontend`, I noticed we have an LGPL licensed dev dependency `po2json`, which is not compliant with [Apache license policies](https://www.apache.org/legal/resolved.html). Since `po2json` package is not being used in either CI or npm scripts, and is only referred to in the [contributing guide](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#updating-language-files) where users are instructed to globally install the package when translating JS files, the dev dependency isn't really needed as a dev dependency. ### AFTER The list doesn't contain any (L)GPL licensed packages: ``` $ npx license-checker --summary ├─ MIT: 2076 ├─ ISC: 159 ├─ BSD-3-Clause: 95 ├─ Apache-2.0: 89 ├─ BSD-2-Clause: 57 ├─ MIT*: 6 ├─ CC0-1.0: 5 ├─ BSD*: 4 ├─ BSD: 4 ├─ Unlicense: 3 ├─ 0BSD: 3 ├─ (MIT OR CC0-1.0): 3 ├─ CC-BY-4.0: 2 ├─ WTFPL: 2 ├─ Custom: https://github.com/tmcw/jsonlint: 1 ├─ (Unlicense OR Apache-2.0): 1 ├─ (MIT OR Apache-2.0): 1 ├─ MPL-2.0: 1 ├─ Custom: https://github.com/saikocat/colorbrewer.: 1 ├─ Apache-Style: 1 ├─ (MPL-2.0 OR Apache-2.0): 1 ├─ Apache*: 1 ├─ AFLv2.1,BSD: 1 ├─ ODC-By-1.0: 1 ├─ Apache-2.0 WITH LLVM-exception: 1 ├─ (BSD-3-Clause OR GPL-2.0): 1 ├─ (WTFPL OR MIT): 1 ├─ (MIT AND Zlib): 1 ├─ (MIT AND BSD-3-Clause): 1 ├─ CC-BY-3.0: 1 ├─ (MIT OR GPL-3.0): 1 └─ Public Domain: 1 ``` ### BEFORE See the reference to "GNU Library General Public License": ``` $ npx license-checker --summary ├─ MIT: 2082 ├─ ISC: 159 ├─ BSD-3-Clause: 95 ├─ Apache-2.0: 89 ├─ BSD-2-Clause: 57 ├─ MIT*: 7 ├─ CC0-1.0: 5 ├─ BSD*: 4 ├─ BSD: 4 ├─ Unlicense: 3 ├─ 0BSD: 3 ├─ (MIT OR CC0-1.0): 3 ├─ CC-BY-4.0: 2 ├─ WTFPL: 2 ├─ Custom: https://github.com/tmcw/jsonlint: 1 ├─ (Unlicense OR Apache-2.0): 1 ├─ (MIT OR Apache-2.0): 1 ├─ MPL-2.0: 1 ├─ Custom: https://github.com/saikocat/colorbrewer.: 1 ├─ Apache-Style: 1 ├─ (MPL-2.0 OR Apache-2.0): 1 ├─ Apache*: 1 ├─ AFLv2.1,BSD: 1 ├─ ODC-By-1.0: 1 ├─ Apache-2.0 WITH LLVM-exception: 1 ├─ (BSD-3-Clause OR GPL-2.0): 1 ├─ (WTFPL OR MIT): 1 ├─ (MIT AND Zlib): 1 ├─ GNU Library General Public License: 1 ├─ (MIT AND BSD-3-Clause): 1 ├─ CC-BY-3.0: 1 ├─ (MIT OR GPL-3.0): 1 └─ Public Domain: 1 ``` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
