suddjian commented on a change in pull request #17123:
URL: https://github.com/apache/superset/pull/17123#discussion_r730047295
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
##########
@@ -230,7 +230,18 @@ export default class Chart extends React.Component {
});
};
- getChartUrl = () => getExploreLongUrl(this.props.formData);
+ getChartUrl = () => {
+ const filters = this.props.formData?.extra_form_data?.filters;
+ // remove formData params that we don't need in the explore url
+ // this should be superseded by some sort of "exploration context" system
+ const formData = {
+ ...this.props.formData,
+ extra_form_data: { filters },
+ native_filters: undefined,
Review comment:
If you set it to `null` it is included as an empty param, but if you use
`undefined` it is left out entirely. But that's not important anyway because I
changed the implementation to use `_.omit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
