[GitHub] [superset] graceguo-supercat opened a new pull request #17133: fix: sql lab crash caused by invalid template

[GitBox]

graceguo-supercat opened a new pull request #17133:
URL: https://github.com/apache/superset/pull/17133


   ### SUMMARY
   If user has invalid template in the query and run the query, SQL Lab will 
crash.
   The error returned from backend seems not compatible with front-end error 
handle logic:
   
   <img width="1135" alt="Screen_Shot_2021-10-15_at_2_07_24_PM" 
src="https://user-images.githubusercontent.com/27990562/137555557-8665c1f8-b435-489a-8938-f780708784f6.png";>
   
   
   
   ### BEFORE/AFTER SCREENSHOTS OR 
   Before: SQL Lab page is blank
   
   After:
   <img width="713" alt="Screen Shot 2021-10-15 at 2 26 16 PM" 
src="https://user-images.githubusercontent.com/27990562/137555408-1b8764b5-c37c-4952-830f-351ccb1807a3.png";>
   
   
   
   ### TESTING INSTRUCTIONS
   CI and manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org