mistercrunch commented on a change in pull request #6512: Fix scheduled reports
for mysql
URL:
https://github.com/apache/incubator-superset/pull/6512#discussion_r245790197
##########
File path: setup.py
##########
@@ -94,9 +94,6 @@ def get_git_sha():
'thrift-sasl>=0.2.1',
'unicodecsv',
'unidecode>=0.04.21',
- 'croniter==0.3.25',
Review comment:
`requirements.txt` is a pip-compiled, "pinned" version of what's in here. We
probably want to keep this in here though I think it belong in an
`extra_requires` sub-category, but that's outside the scope of this PR. For now
let's just keep this in the repo. Mind remove these edits from this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
