hughhhh commented on a change in pull request #17155:
URL: https://github.com/apache/superset/pull/17155#discussion_r733014380
##########
File path: superset/sql_lab.py
##########
@@ -291,6 +287,18 @@ def execute_sql_statement( # pylint:
disable=too-many-arguments,too-many-locals
return SupersetResultSet(data, cursor_description, db_engine_spec)
+def apply_limit_if_exists(
+ database: Database, increased_limit: Optional[int], query: Query, sql: str
+) -> str:
+ if query.limit and increased_limit:
Review comment:
we don't need to check the query.limit since it is already a part of the
`increased_limit` logic
https://github.com/apache/superset/blob/master/superset/sql_lab.py#L195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
