villebro commented on pull request #17168: URL: https://github.com/apache/superset/pull/17168#issuecomment-948273846
@zhaoyongjie does the filter box use this same endpoint? IIRC, the filter box select works with null values (the native filter one does, too, but it uses the chart data endpoint for this so won't be affected). If this doesn't affect the filter box then LGTM, otherwise we may need to add an additional param to the endpoint path to toggle between allowing/disallowing nulls and calling it without nulls only on the adhoc filter request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
