geido opened a new pull request #17184: URL: https://github.com/apache/superset/pull/17184
### SUMMARY This PR removes the PropertiesModal entirely on close. In this way changes to be cancelled will be automatically wiped out. Performance should not be an issue as the queries performed within this component will soon be moved one level up in this PR https://github.com/apache/superset/pull/17089. ### BEFORE See https://github.com/apache/superset/issues/17170 ### AFTER https://user-images.githubusercontent.com/60598000/138289541-47c49fed-b87f-4b78-bc00-1ebd03829616.mp4 ### TESTING INSTRUCTIONS 1. Open Explore 2. Edit the properties 3. Click on Cancel 4. Re-open the modal and make sure the changes are gone ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes https://github.com/apache/superset/issues/17170 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
