rusackas commented on pull request #17145: URL: https://github.com/apache/superset/pull/17145#issuecomment-949264954
> * in the click handler you can decide open in the same window or open another window I think this is the center of the issue. With the click handler, _the developer_ must decide to open in the same window or in a new tab/window. With an old-school `href` link, the _user_ has the choice of opening in the same window or opening in a new tab. Giving the user the choice was the reason for going that route. An onClick handler _might_ be able to capture modifier keys to emulate this behavior, but it would not have the same level of support (no right click menu, accessibility concerns). The longer term idea we're stewing on would be a combination... opening the context menu could do a POST to push all the context of the dashboard (or other superset object, potentially) into a database row, and return a URL with a slug. That short URL could be used _in a conventional link_ to take you to Explore (or other superset area) which would look up all of the state/context needed to load as desired. Approving this PR since it improves the existing feature. Going back to a simple onClick/POST will just rekindle the usability discussions we've had before. I think if we build a system like I'm (only briefly) attempting to describe above, it will solve the long URL problem AND improve accessibility/usability for this instance, and perhaps several other areas of Superset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
