michael-s-molina commented on a change in pull request #17171:
URL: https://github.com/apache/superset/pull/17171#discussion_r734488505
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -82,17 +82,80 @@ export type OptionsPagePromise = (
) => Promise<OptionsTypePage>;
export interface SelectProps extends PickedSelectProps {
Review comment:
Can we add a description to the component as well? Some things that can
be in the description:
- The different modes of operation (static and async)
- The differences and motivation that lead us to increment the default Ant
Design Select.
- The reasoning/criteria for not exposing some props but instead using
default values (simplification, standard behavior)
- A reference to the Storybook file
- A reference to the Ant Design API for the other properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
