eschutho commented on a change in pull request #16977:
URL: https://github.com/apache/superset/pull/16977#discussion_r734825733
##########
File path: superset/reports/notifications/email.py
##########
@@ -89,11 +89,7 @@ def _get_content(self) -> EmailContent:
html_table = ""
call_to_action = __("Explore in Superset")
- img_tag = (
- f'<img width="1000px" src="cid:{msgid}">'
- if self._content.screenshot
- else ""
- )
+ img_tag = f'<img src="cid:{msgid}">' if self._content.screenshot else
""
Review comment:
I think this could potentially be a breaking change for people. Best to
wait until 2.0 for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
