simcha90 opened a new pull request #17208: URL: https://github.com/apache/superset/pull/17208
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR POC feat for dynamic loading of dashboard components **Why?** Dependent on product needs we want to take development of Superset to different directions. `Dashboard Components` can introduce specific needs of company requirements. So we wanted to do this feature more flexible in order to not affect other product visions :) **What?** This PR add opportunity to add new `Dashboard Components` that can be configured in separate file by every superset instance and not affects main Superset functionality **How?** We creating new dashboard components registry that can register new `Dashboard Components` in `/src/setup/setupDasboardComponents.ts` When we drag new component to dashboard we use `React.lazy` function to load code of component **NOTES:** - We created new type of registry using functional approach in favor of class approach that we are using now for loading plugin charts - We have some basic predefined rules for dynamic components ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> https://user-images.githubusercontent.com/56388545/138594705-32b5a862-295f-4111-a63b-d8e8c96fcb7e.mov ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
