villebro commented on a change in pull request #17200:
URL: https://github.com/apache/superset/pull/17200#discussion_r735506281
##########
File path:
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
##########
@@ -365,7 +378,12 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => {
) : (
<Loading />
)}
- {editMode && <BuilderComponentPane topOffset={barTopOffset} />}
+ {editMode && (
+ <BuilderComponentPane
+ isStandalone={!!StandaloneMode}
Review comment:
This is a bit of a tangent and not caused by this PR, but this caused
some confusion when reviewing this, so... Should we rename `StandaloneMode` to
`standaloneMode`? Also, I noticed that `DashboardStandaloneMode` does not have
the value `0`, which could IMO be added to the enum as e.g.
`DashboardStandaloneMode.NONE`:
https://github.com/apache/superset/blob/ef3afbde82727d1d9df6e3cdc936e2d92f14c5ca/superset-frontend/src/dashboard/util/constants.ts#L73-L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
