[GitHub] [superset] michael-s-molina opened a new pull request #17216: chore: Removes the ChartIcon component

[GitBox]

michael-s-molina opened a new pull request #17216:
URL: https://github.com/apache/superset/pull/17216


   ### SUMMARY
   This PR removes the `ChartIcon` component and replaces the code with an icon 
from our `Icons` component.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1430" alt="Screen Shot 2021-10-25 at 11 30 51 AM" 
src="https://user-images.githubusercontent.com/70410625/138715337-f65a00b0-3bf2-420b-8fa1-badfa5522ce7.png";>
   
   <img width="1427" alt="Screen Shot 2021-10-25 at 11 27 16 AM" 
src="https://user-images.githubusercontent.com/70410625/138715370-9b04ff51-64fa-4614-b48e-76091855deff.png";>
   
   ### TESTING INSTRUCTIONS
   1 - Open a dashboard
   2 - Enter in edit mode
   3 - Click on the 3 dots on the right top corner
   4 - Click on Set filter mapping
   5 - See the changes  
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org