john-bodley edited a comment on pull request #16318: URL: https://github.com/apache/superset/pull/16318#issuecomment-951450492
@villebro this seems like a breaking change and thus my sense is it should be behind a feature flag. Note I understand the use case but it could be seen as a regression in terms of UX, i.e., it's not apparent to the user that the group-by temporal columns are also subject to the granularity which historically only applies to the temporal column. Also as you mentioned there may be existing cases which this pattern breaks—like when the time grains need to be decoupled. An alternative approach—which requires more user work and isn't as dynamic—is to add custom columns which are granularity specific. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
