villebro opened a new pull request #17234: URL: https://github.com/apache/superset/pull/17234
### SUMMARY Currently it's possible to create annotations and annotation layers via the API that cause the frontend to crash. For instance, by defining an annotation layer with a `null` name, the edit window crashes with the following error:  This PR updates both the annotation layer and annotation marshmallow schemas to require the minimum amount of defined or non-null values. Note that when leaving out a property on a PUT request, the original object leaves the omitted values untouched, hence a very permissive schema for PUT operations (no required fields). In addition, the frontend logic is updated to no longer crash if an object that was created prior to this PR is edited. Test cases are added to all relevant permutations of allowed and incorrect POST/PUT payloads. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
