michael-s-molina opened a new pull request #17268:
URL: https://github.com/apache/superset/pull/17268


   ### SUMMARY
   There was a bug when changing log retention to None in the alerts modal. 
This PR fixes this bug.
   This PR also creates a new test for this case in a new test file using RTL. 
Previous tests are written with Enzyme.
   
   @rusackas @junlincc 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/139282367-afe92f6a-cc75-4eea-b58f-b03818af51cf.mov
   
   
https://user-images.githubusercontent.com/70410625/139282528-a89d3b39-ac5a-455e-bb64-ad321a75f9d2.mov
   
   ### TESTING INSTRUCTIONS
   Check the videos for instructions.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to