betodealmeida opened a new pull request #17275: URL: https://github.com/apache/superset/pull/17275
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The migration in https://github.com/apache/superset/pull/16756 is failing in MySQL 8. Renaming the column `dbs.allow_csv_upload` fails because there's a check constraint on it. This seems to be a known bug (https://github.com/sqlalchemy/alembic/issues/699), and from that thread dropping the constraint seems safe. The problem is that existing installations already have the constraint, so we can't add `create_constraint=False` to boolean columns in the model. This PR fixes the migration by explicitly dropping the check constraint if it exists, and renaming the column after. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Install Superset using a MySQL 8 database. The `superset db upgrade` step will fail on the migration `b92d69a6643c_rename_csv_to_file.py`. With this PR, the check constraint is dropped and the migration succeeds. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
