[GitHub] [superset] kgabryje opened a new pull request #17287: fix(dashboard): Return columns and verbose_map for groupby values of Pivot Table v2

Fri, 29 Oct 2021 06:46:39 -0700 


kgabryje opened a new pull request #17287:
URL: https://github.com/apache/superset/pull/17287


   ### SUMMARY
   Columns used by Pivot Table v2 were not processed correctly by 
`/dashboard/{id}/datasets` endpoint, resulting in chart not displaying custom 
column labels when added to dashboard. This PR fixes the issue.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![image](https://user-images.githubusercontent.com/15073128/139445984-64578d17-6809-43ad-a54f-0d55f43e5cee.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/15073128/139445573-f4beddbb-1628-400a-a97a-2001a1a4fd42.png)
   
   
   ### TESTING INSTRUCTIONS
   1. Create a pivot table v2 chart using columns with custom labels
   2. Add the chart to dashboard
   3. Verify that custom labels are used instead of column_names
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to