john-bodley opened a new pull request #17312: URL: https://github.com/apache/superset/pull/17312
### SUMMARY This PR fixes a regression introduced in https://github.com/apache/superset/pull/16795 as not all temporal columns are of type `TIMESTAMP`. The solution (as outlined in https://github.com/apache/superset/pull/16795#issuecomment-955122235) uses the SQLA connector to convert the date time appropriately. ### TESTING INSTRUCTIONS Added unit tests. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
