Damans227 commented on a change in pull request #17315:
URL: https://github.com/apache/superset/pull/17315#discussion_r740622652
##########
File path: superset-frontend/src/explore/components/controls/HiddenControl.tsx
##########
@@ -17,29 +17,14 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import { Input } from 'src/common/components';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([
- PropTypes.string,
- PropTypes.number,
- PropTypes.object,
- PropTypes.bool,
- PropTypes.array,
- PropTypes.func,
- ]),
-};
-
-const defaultProps = {
- onChange: () => {},
-};
+interface HiddenControlsProps {
+ onChange: () => void;
+ value: string | number | {} | boolean | [] | (() => void);
Review comment:
Thanks for the feedback. I have committed the suggested changes, and
will keep them in mind for future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
