villebro opened a new pull request #17325:
URL: https://github.com/apache/superset/pull/17325


   ### SUMMARY
   Update `superset-websocket` deps to resolve audit warnings + resolve 
conflicts due to bump to jest 27. After update `npm run test` passed and 
running Superset with Global Async Queries with websocket server worked as 
expected.
   
   ### AFTER
   All vulnerabilities fixed:
   ```
   $ npm audit
   found 0 vulnerabilities
   ```
   
   ### BEFORE
   Multiple 
   ```
   $ npm audit
   # npm audit report
   
   ansi-regex  >2.1.1 <5.0.1
   Severity: moderate
    Inefficient Regular Expression Complexity in chalk/ansi-regex - 
https://github.com/advisories/GHSA-93q8-gq69-wqmw
   fix available via `npm audit fix`
   node_modules/ansi-regex
   
   set-value  <4.0.1
   Severity: high
   Prototype Pollution in set-value - 
https://github.com/advisories/GHSA-4jqc-8m5r-9rpr
   fix available via `npm audit fix --force`
   Will install [email protected], which is a breaking change
   node_modules/set-value
     cache-base  >=0.7.0
     Depends on vulnerable versions of set-value
     Depends on vulnerable versions of union-value
     node_modules/cache-base
       base  >=0.7.0
       Depends on vulnerable versions of cache-base
       node_modules/base
         snapdragon  0.6.0 - 0.10.1
         Depends on vulnerable versions of base
         node_modules/snapdragon
           braces  2.0.0 - 2.3.2
           Depends on vulnerable versions of snapdragon
           node_modules/sane/node_modules/braces
           expand-brackets  1.0.0 - 2.1.4
           Depends on vulnerable versions of snapdragon
           node_modules/expand-brackets
           extglob  1.0.0 - 2.0.4
           Depends on vulnerable versions of snapdragon
           node_modules/extglob
           micromatch  3.0.0 - 3.1.10
           Depends on vulnerable versions of snapdragon
           node_modules/sane/node_modules/micromatch
             anymatch  2.0.0
             Depends on vulnerable versions of micromatch
             node_modules/sane/node_modules/anymatch
             sane  2.5.0 - 4.1.0
             Depends on vulnerable versions of micromatch
             node_modules/sane
               jest-haste-map  24.0.0-alpha.0 - 26.6.2
               Depends on vulnerable versions of sane
               node_modules/jest-haste-map
                 @jest/core  <=26.6.3
                 Depends on vulnerable versions of jest-config
                 Depends on vulnerable versions of jest-haste-map
                 Depends on vulnerable versions of jest-snapshot
                 node_modules/@jest/core
                   jest  24.2.0-alpha.0 - 26.6.3
                   Depends on vulnerable versions of @jest/core
                   Depends on vulnerable versions of jest-cli
                   node_modules/jest
                   jest-cli  24.2.0-alpha.0 - 26.6.3
                   Depends on vulnerable versions of @jest/core
                   Depends on vulnerable versions of jest-config
                   node_modules/jest/node_modules/jest-cli
                 @jest/reporters  <=26.6.2
                 Depends on vulnerable versions of jest-haste-map
                 node_modules/@jest/reporters
                 @jest/test-sequencer  <=26.6.3
                 Depends on vulnerable versions of jest-haste-map
                 node_modules/@jest/test-sequencer
                   jest-config  24.2.0-alpha.0 - 26.6.3
                   Depends on vulnerable versions of @jest/test-sequencer
                   Depends on vulnerable versions of babel-jest
                   Depends on vulnerable versions of jest-jasmine2
                   node_modules/jest-config
                     jest-runner  24.0.0-alpha.0 - 26.6.3
                     Depends on vulnerable versions of jest-config
                     Depends on vulnerable versions of jest-haste-map
                     node_modules/jest-runner
                     jest-runtime  24.0.0-alpha.0 - 26.6.3
                     Depends on vulnerable versions of @jest/transform
                     Depends on vulnerable versions of jest-config
                     Depends on vulnerable versions of jest-haste-map
                     Depends on vulnerable versions of jest-snapshot
                     node_modules/jest-runtime
                       jest-jasmine2  24.2.0-alpha.0 - 26.6.3
                       Depends on vulnerable versions of jest-runtime
                       Depends on vulnerable versions of jest-snapshot
                       node_modules/jest-jasmine2
                 @jest/transform  <=26.6.2
                 Depends on vulnerable versions of jest-haste-map
                 node_modules/@jest/transform
                   babel-jest  24.2.0-alpha.0 - 26.6.3
                   Depends on vulnerable versions of @jest/transform
                   node_modules/babel-jest
                 jest-snapshot  24.2.0-alpha.0 - 24.5.0 || 26.1.0 - 26.6.2
                 Depends on vulnerable versions of jest-haste-map
                 node_modules/jest-snapshot
                   jest-resolve-dependencies  26.1.0 - 26.6.3
                   Depends on vulnerable versions of jest-snapshot
                   node_modules/jest-resolve-dependencies
           nanomatch  >=0.1.1
           Depends on vulnerable versions of snapdragon
           node_modules/nanomatch
     union-value  *
     Depends on vulnerable versions of set-value
     node_modules/union-value
   
   tmpl  <1.0.5
   Severity: moderate
   Regular Expression Denial of Service in tmpl - 
https://github.com/advisories/GHSA-jgrx-mgxx-jf9v
   fix available via `npm audit fix`
   node_modules/tmpl
   
   28 vulnerabilities (2 moderate, 26 high)
   
   To address issues that do not require attention, run:
     npm audit fix
   
   To address all issues (including breaking changes), run:
     npm audit fix --force
   ```
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to