graceguo-supercat commented on a change in pull request #17278:
URL: https://github.com/apache/superset/pull/17278#discussion_r741417984
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps
to reproduce this issue`. Other people, like QA or reviewers, read your
description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged,
it might impact all the users in the Superset community.
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps
to reproduce this issue`. Other people, like QA or reviewers, read your
description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged,
it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run ```
npm run lint
```
in your own development environment, and see what is broken.
##########
File path: superset/config.py
##########
@@ -87,6 +87,11 @@
# },
FAVICONS = [{"href": "/static/assets/images/favicon.png"}]
+FEATURE_FLAGS = {
Review comment:
you can list the necessary feature flags in the description, like `Steps
to reproduce this issue`. Other people, like QA or reviewers, read your
description and reproduce your issue in their local development environment.
But you should not commit these feature flags in the PR. Once it is merged,
it might impact all the users in the Superset community.
You also need to fix the linting errors. You can run
```
npm run lint
```
in your own development environment, and see what is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
