geido opened a new pull request #17335: URL: https://github.com/apache/superset/pull/17335
### SUMMARY This PR: - Allows to certify charts and filter them out - Refactors the PropertiesModal to use the built-in Antd form functionalities instead of polluting the state ### AFTER https://user-images.githubusercontent.com/60598000/140119342-dcf41a06-7fb6-4590-a795-3c5309619ab1.mp4 ### TODO - Validate with design - In PropertiesModal clear certification_details when certified_by is cleared and saved - Add tests for the certified_by and certification_details in the frontend - Add tests for the API - Clean up ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
